Query about Manjaro-ZSH-Config

Shirshendu · 31 May 2023 12:06

What are the functions of the hooks mzc_termsupport_precmd, mzc_termsupport_preexec in manjaro-zsh-config? I am curious as these hooks are somehow stopping wezterm from correctly getting the working directory from OSC 7 sequence.

Tomek · 31 May 2023 16:51

These functions set window title depending on executed command.

github.com

ohmyzsh/ohmyzsh/blob/master/lib/termsupport.zsh

# Set terminal window and tab/icon title
#
# usage: title short_tab_title [long_window_title]
#
# See: http://www.faqs.org/docs/Linux-mini/Xterm-Title.html#ss3.1
# Fully supports screen, iterm, and probably most modern xterm and rxvt
# (In screen, only short_tab_title is used)
# Limited support for Apple Terminal (Terminal can't set window and tab separately)
function title {
  setopt localoptions nopromptsubst

  # Don't set the title if inside emacs, unless using vterm
  [[ -n "${INSIDE_EMACS:-}" && "$INSIDE_EMACS" != vterm ]] && return

  # if $2 is unset use $1 as default
  # if it is set and empty, leave it as is
  : ${2=$1}

  case "$TERM" in
    cygwin|xterm*|putty*|rxvt*|konsole*|ansi|mlterm*|alacritty|st*|foot|contour*)

This file has been truncated. show original

Shirshendu · 1 June 2023 01:28

Thanks a lot. Problem solved

pheiduck · 2 June 2023 08:28

If @Chrysostomus is not around I will do a patch release which include your PR:

pheiduck · 2 June 2023 09:46

Patch is applied.:

Shirshendu · 2 June 2023 16:19

Thanks a lot. I added the commit for the actual fix just now. Please have a look.

pheiduck · 2 June 2023 17:25

Yep, LGTM the whole PR is added to 0.25-3 so no changes needed.
Just test it in unstable when core team will pull new packages to this branch.

pheiduck · 2 June 2023 18:29

manjaro-zsh-config 0.25-3

is now avaible in all branches

system · 5 June 2023 08:29

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.