Enable for PCIE 3.0 on Rockchip SoC

ARM
1

I have been trying to get the nvme SSD to work on the Rock 3a dev board (PCIE 3.0) but it fails to initialize.

It need CONFIG_PHY_ROCKCHIP_NANENG_COMBO_PHY=y in defconfig.

Right now only PCIE2 is recognized with the latest kernel image.
Please enable this config option

alarm@rock-3a:~$ uname -a
Linux rock-3a 6.1.0-rc1-2-MANJARO-ARM-RC #1 SMP PREEMPT Mon Oct 17 16:43:21 UTC 2022 aarch64 GNU/Linux
alarm@rock-3a:~$ lspci
00:00.0 PCI bridge: Rockchip Electronics Co., Ltd RK3568 Remote Signal Processor (rev 01)
01:00.0 Network controller: Intel Corporation Wireless 8265 / 8275 (rev 78)
alarm@rock-3a:~$
2

@Strit Please do consider enable CONFIG_PHY_ROCKCHIP_NANENG_COMBO_PHY=y in manjaro defconfig,
it will help enable PCI 3.0 phy with NVMe devices.

3

Is there a reason why it needs to be y and therefore enabled on all devices, instead of m and probed on devices that has the hardware?

PS: Enabled with set NANENG_COMBO_PHY to y instead of m (2f5c40f7) · Commits · manjaro-arm / packages / core / linux · GitLab just now.

4

Since we have different combo phy for USB and PCIe and SATA on Rockchip SbC
in my testing, it was observed to fail to bring up PCIe 3 phy see below error on rock-3a
I know that all the PHY drivers are built into the kernel image.

[ 0.554377] Key type fscrypt-provisioning registered
[ 0.554901] Key type encrypted registered
[ 0.628836] phy phy-fe8c0000.phy.4: lane number 0, val 1
[ 0.629362] phy phy-fe8c0000.phy.4: rockchip_p3phy_rk3568_init: lock failed 0x6890000, check input refclk and power supply
[ 0.629374] phy phy-fe8c0000.phy.4: phy init failed → -110
[ 0.629506] rockchip-dw-pcie: probe of 3c0800000.pcie failed with error -110
[ 0.641987] ALSA device list:

5

Okay, the kernel with the module built-in is now in unstable branch.

6

ok will check for next kernel update thanks,

7

Ok, now it works fine with the latest update kernel.

alarm@rock-3a:~$ uname -a
Linux rock-3a 6.0.3-3-MANJARO-ARM #1 SMP PREEMPT Tue Oct 25 08:09:14 UTC 2022 aarch64 GNU/Linux
alarm@rock-3a:~$ lspci
0000:00:00.0 PCI bridge: Rockchip Electronics Co., Ltd RK3568 Remote Signal Processor (rev 01)
0000:01:00.0 Network controller: Intel Corporation Wireless 8265 / 8275 (rev 78)
0002:00:00.0 PCI bridge: Rockchip Electronics Co., Ltd RK3568 Remote Signal Processor (rev 01)
0002:01:00.0 Non-Volatile memory controller: Micron/Crucial Technology P2 NVMe PCIe SSD (rev 01)