Rename `install-grub` to prevent confusion from `grub-install`

Feedback
8

Indeed.

And in the heat of the moment some of us created other polls [1] [2] in an attempt to detract from the original binary vision (install-grub vs. grub-reinstall).

In retrospect, HansGrubber should have been a fair contender.

With the benefit of hindsight manjaro-grub-installer does seem the most obvious candidate if the tool is to be officially renamed.

In fact, it does even more than that. Several safety checks were also added to this mechanism that didn’t exist before; at least, not in the tools previously adopted by Manjaro.

For example, a check for other loaders in the UEFI fallback location:

efi_source_file="$efi_directory/EFI/$bootloader_id/$efi_grub_file"
efi_target_file="$(find $path -name $efi_boot_file)"
if [[ -e "$efi_source_file" ]] && [[ -e "$efi_target_file" ]]; then
    cmp -s "$efi_source_file" "$efi_target_file" && fallback_is_same=true
fi

which overwrites a file only if conditions are right:

if [[ "$grub_type" == "EFI" ]] && [[ -e "$efi_source_file" ]] && [[ -e "$efi_target_file" ]] \
     && [[ "$fallback_is_same" == "true" ]] && [[ "$failed_update" == "false" ]]; then
    echo "Update UEFI Fallback file: $efi_source_file"
    cp "$efi_source_file" "$efi_target_file"
fi

The ‘John McClane’ of Grub Installers.

2 Likes