What is wrong with this script for my xfce panel?

Support Xfce
1

image

This is the script that i found: (https://stackoverflow.com/questions/52354782/linux-cpu-and-memory-percentages/70685230#70685230)

#!/bin/bash

CPU=$(lscpu | grep '\(CPU\|max\) MHz:' | xargs echo | awk '{printf "%3.0f\n", $3*100/$7}')
MEM=$(free | grep Mem | awk '{printf "%3.0f\n", $3*100/$2}')
echo CPU $CPU% \| MEM $MEM%
2

Have you checked the result of each command?

2 Likes
3

Try now:

#!/bin/bash

CPU=$(top -bn1 | grep load | awk '{printf "%.2f%\n", $(NF-2)}')
MEM=$(free -t | awk 'NR == 2 {printf "%.2f%\n", $3/$2*100}')
echo CPU $CPU \| MEM $MEM

Also make sure the script is executable:

chmod +x my_script.sh
2 Likes
4

This does not provide any useful output.

1 Like
5

No.
I havent tought about this.
I will. Thanks

6

I tried, now it indicates the cpu value, but its 1-3%. Not really real data.

But i really appreciate your work!

7

Maybe this then:

#!/bin/bash

CPU=$(top -bn1 | grep "Cpu(s)" | \
           sed "s/.*, *\([0-9.]*\)%* id.*/\1/" | \
           awk '{print 100 - $1"%"}')
MEM=$(free -t | awk 'NR == 2 {printf "%.2f%\n", $3/$2*100}')
echo CPU $CPU \| MEM $MEM
8

Man, i’m really thankful, but it seems like dosn’t work either:

image
image836Ă—264 43.9 KB

9

although I still don’t fully understand that sed line
and could never have come up with it myself:
there should be a comma after id (the third line of the “top” output)

the above is not a quote anymore as I already changed that :wink:

… and it only works reliably if I set LANG=C as well …

ps (a few hours later):
the original script does work when setting LANG=C in the calling terminal or in the script
So: it is probably not the comma / point after id in the sed line
(which I do not understand)
but something else

comma or point makes no difference - but the LANG setting does
it ensures consistency
different LANG settings produce slightly different output
some use decimal point, some comma - and the first column varies between %Cpu(s): and %CPU(s):
so that the grep command returns empty handed in one case
tricky :wink:

3 Likes