Fix For Installing ARM Edition To NVMe Drive

ARM General ARM Discussion
1

The manjaro-arm-installer crashed when I tried to use it to install Manjaro ARM to the NVMe drive in my Pinebook Pro. I fixed it by changed it by changing "$SDTYP" = "mm" to "$SDTYP" = "nv". I’ve since then made a proper fix for the issue. The patch is untested but it should work.

The original script checked to see if the name of the block device to install to started with sd or mm, and exited if it didn’t match. This patch changes the check for mm alone to a check for either mm or nv, which should cover NVMe drives properly.

The patch follows below this line.

--- /usr/bin/manjaro-arm-installer	2021-10-27 18:50:11.000000000 +0000
+++ ./manjaro-arm-installer	2022-01-08 02:53:45.406660766 +0000
@@ -665,7 +665,7 @@
 
 if [[ "$SDTYP" = "sd" ]]; then
     SDDEV=""
-elif [[ "$SDTYP" = "mm" ]]; then
+elif [[ "$SDTYP" = "mm" || "$SDTYP" = "nv" ]]; then
     SDDEV="p"
 else 
     clear
2 Likes
2

Be aware though, that as far as I know, the Pinebook Pro is not able to boot with only an nvme installed. It needs uboot on either SPI, eMMC or SD to be able to use NVME drives.

But yeah, should probably include your little fix. :slight_smile:

3

You should also add an error message if the script can’t figure out what the selected block device is.
When the script crashed for me, it returned me to an empty terminal after selecting the NVMe drive. No explanation on what went wrong or what the script was expecting.
Maybe

else
    clear
    echo "unknown block device type"
    exit 1
fi

right below where my patch goes?

EDIT: A patch in the proper format:

--- /usr/bin/manjaro-arm-installer      2021-10-27 14:50:11.000000000 -0400
+++ ./manjaro-arm-installer     2022-01-10 17:53:37.230000421 -0500
@@ -669,6 +669,7 @@
     SDDEV="p"
 else 
     clear
+    echo "Unkown Block Device Type"
     exit 1
 fi
2 Likes
4

Thanks. Added to git master.